-
Notifications
You must be signed in to change notification settings - Fork 774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[D1] add a json option to execute #2627
Conversation
🦋 Changeset detectedLatest commit: 7deb4b4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## main #2627 +/- ##
==========================================
+ Coverage 73.32% 73.34% +0.02%
==========================================
Files 159 159
Lines 9852 9853 +1
Branches 2627 2627
==========================================
+ Hits 7224 7227 +3
+ Misses 2628 2626 -2
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/runs/4026409715/npm-package-wrangler-2627 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/prs/2627/npm-package-wrangler-2627 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/runs/4026409715/npm-package-wrangler-2627 dev path/to/script.js Additional artifacts:npm install https://prerelease-registry.devprod.cloudflare.dev/runs/4026409715/npm-package-cloudflare-pages-shared-2627 |
I'm a bit iffy on this being an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of checks for if(!json)
. Would setting the log level to "none" have the same effect?
Co-authored-by: Somhairle MacLeòid <[email protected]>
…dflare/wrangler2 into rozenmd/d1-exec-json-output
@penalosa - if it was decided to make |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Pending tests
What this PR solves / how to test:
With a workaround, it's possible to make wrangler return almost clean JSON:
We should just return JSON (and nothing else) when the user asks for it - hence
--json
Before:
After:
Associated docs issues/PR:
- [insert associated docs issue(s)/PR(s)]Author has included the following, where applicable:
- [ ] TestsReviewer has performed the following, where applicable:
- [ ] Checked for inclusion of relevant tests- [ ] Checked for creation of associated docs updatesResolves #2415